[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] prompt string for client

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2005-09-28 16:24:53 CEST

On Wed, Sep 28, 2005 at 09:36:01AM -0400, Tom Gordon wrote:
> I would like to prompt the user to enter a Bug Id and who reviewed the
> code on the client, before sending the commit to the server.

This is issue 1973, log message templates. Your patch is fine for your
users, but obviously isn't appropriate in the general case.

The last time this came up, there was a long discussion, but I don't
think there was any concrete conclusion. Summarising from memory:

* Log message templates could be per-project, which might not be the
  same thing as per-repository.

* It seemed to be a foregone conclusion that you'd want to store the
  template in the repository (is this a CVS parity issue? I'm not familiar
  with CVS).

* Given that, how and when would you communicate the template from the
  server to the client?

* One suggestion was via a property set on a parent directory, but
  that would require inheritable properties, and runs into problems when
  you commit across two directories with different templates (although,
  as someone pointed out, you may _already_ be in trouble in that case,
  unless you can use a log message that's a superset of both).

* Another suggestion was that the client could call a hook to generate
  the template (giving maximum flexibility), but that would mean that you
  had to be online to start a checkin (at the moment, you can run 'svn ci'
  and use the default template), and the performance probably wouldn't be
  great (an extra round-trip before every checkin). Another big problem
  with this suggestion was that GUI clients want to be able to present a
  comment box before they've finished working out which files are
  affected, which wouldn't be possible with this change.

You probably didn't need to know all that, but it might be useful if
we're going to restart the discussion at some point.

I'm not sure what the current plans are for this issue (if any), though
at one point it was on a roadmap for post-1.3 development. Karl?

In short:
  * It's a known issue.
  * It's quite complex.
  * No-one seems to be working on it at the moment.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 28 16:26:10 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.