[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Proposal for $ReposRoot$ keyword

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-09-28 14:37:17 CEST

John Peacock wrote:
> I've had a little time to work on add $ReposRoot$ as a new keyword and
> it's gone very smoothly except for the export case, which is a problem.
> Why, oh why, doesn't export use exactly the same library calls as
> checkout except for writing the admin files? There is no RA session
> available from within export.c:add_file, so I have to set one up just so
> I can call svn_ra_get_repos_root. It's a pain.
>
> Does anyone care enough about having a keyword for $ReposRoot$ added
> that I should struggle trying to get this to work?

I don't, personally. I would be more interested in seeing the "export" code
and the "checkout" code brought more into line with each other, but I don't
suppose you'd be interested in doing that.

> I've attached my
> patch in progress, mostly as a demonstration of how simple it is to add
> keywords now.

That's fine as a demonstration. If you want it added to Subversion I'd like to
hear a bit more justification for it.

> === subversion/include/svn_subst.h
> ==================================================================
> --- subversion/include/svn_subst.h (revision 15781)
> +++ subversion/include/svn_subst.h (local)
> @@ -115,6 +115,7 @@
> svn_subst_build_keywords2 (apr_hash_t **kw,
> const char *keywords_string,
> const char *rev,
> + const char *repos,
> const char *url,

I note that adding a new keyword in this function requires an API change
(though it would be possible to implement a new keyword without adding it in
this function). That's not a problem, just another thing to do in any such
patch that will be applied after the version 1.3 API is released.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 28 14:38:24 2005

This is an archived mail posted to the Subversion Dev mailing list.