1.3 now blocking on path escaping in httpd operational logging

kfogel@collab.net writes:
> So, put me down as in favor of the URI-encoding solution for now.
>
> I don't think anyone really objected to it, besides me, so I'll just
> commit that.

The world turns out to be more complex than we thought. I started to
make this change, and soon encountered the following code in
subversion/mod_dav_svn/deadprops.c:

   /* Tell the logging subsystem about the revprop change. */
   apr_table_set(db->resource->info->r->subprocess_env, "SVN-ACTION",
                 apr_psprintf(db->resource->pool,
                              "revprop-change r%" SVN_REVNUM_T_FMT
                              " '%s'", db->resource->info->root.rev,
                              propname));

Looks like we don't just use single quotes to delimit paths, we use
them to delimit property names as well! And converting that to
URI-encoding would be odd. It would "work", but would it really be
appropriate?

I think this problem is now too deep to allow us to branch for 1.3
today, sorry. We're going to have to figure out exactly how we want
to escape paths (and propnames, and anything else that comes up)
before we can consider the mod_dav_svn operational logging feature to
be complete. Technically, we don't have to quote paths in the same
way as propnames -- but we do need *some* way to quote propnames.
Whether we use it (instead of URI-encoding) for paths as well is an
open question.

I don't have any brilliant ideas for quoting methods, beyond the
backtick-quoting (note that's backtick, not backslash) proposal in my
earlier mail.

   http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=105914

Thoughts?

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org