Re: Pathnames in mod_dav_svn log messages (was Re: 1.3 releasenotes)

kfogel@collab.net writes:
> I think this lays out all the issues. If I've forgotten any arguments
> in favor of the URI-encoding solution, my apologies -- no omissions
> were deliberate.
>
> What should we do?
>
> I feel like the "these are paths not URLs" argument is still pretty
> compelling. Also, when discussing it in IRC I did not offer the above
> examples from actual logs, so I don't know what Justin and Mike will
> think after reading this message. Justin? Mike? Others? Bueller?

On considering the whole sitation, I'm beginning to think we should
just URI-encode, since it's easy and known to be safe right now
(w.r.t. terminal output, which I forgot to mention before).

If users really have a problem with it, we can later add a config knob
to control the encoding, and make some sort of single-quote delimited
format or whatever. This would be an easy change, and would not break
compatibility, since we'd continue to support URI-encoding as the
default (even if in our example conf files, we choose to show the knob
set in the custom-encoding position).

So, put me down as in favor of the URI-encoding solution for now.

I don't think anyone really objected to it, besides me, so I'll just
commit that.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org