Re: svn commit: r16237 - trunk/packages/rpm/redhat-7.x

On 9/24/05, David Summers <david@summersoft.fay.ar.us> wrote:
>
> On Sat, 24 Sep 2005, David Summers wrote:
>
> > On Sat, 24 Sep 2005, David James wrote:
> >
> >> On 9/24/05, david@tigris.org <david@tigris.org> wrote:
> >>> # Install Python bindings.
> >>> -make install-swig-py DESTDIR=$RPM_BUILD_ROOT
> >>> DISTUTIL_PARAM=--prefix=$RPM_BUILD_ROOT
> >>> +make install-swig-py DESTDIR=$RPM_BUILD_ROOT
> >>> mkdir -p $RPM_BUILD_ROOT/usr/lib/python2.2/site-packages
> >>> mv $RPM_BUILD_ROOT/usr/lib/svn-python/*
> >>> $RPM_BUILD_ROOT/usr/lib/python2.2/site-packages
> >>> +(cd
> >>> $RPM_BUILD_DIR/%{name}-%{version}/subversion/bindings/swig/python/.libs/
> >>> +for i in _*.soU
> >>> +do
> >>> + n=`basename $i U`
> >>> + mv $i $RPM_BUILD_ROOT/usr/lib/python2.2/site-packages/libsvn/$n
> >>> +done
> >>> +)
> >>> rmdir $RPM_BUILD_ROOT/usr/lib/svn-python
> >> David, thanks for figuring out the solution to this problem! I'd like
> >> to move your code into the standard Python installer, so that we can
> >> correctly do "DESTDIR" installations out of the box on all systems
> >> which require this extra incantation. Ideas?
> >>
> >
> > Followup. I could send you the RPM output so you could see what is happening
> > if you would like. The libtool fails on relinking but it doesn't correctly
> > error because it is inside a shell "()" construct which ignores errors.
> >
>
> Second followup. It might be something as simple as providing the right
> link directory -L option for the -lsvn_swig_py library during the relink.
> But I'm not sure how to tell it that.
Aha! Here's the line of code in build-outputs.mk that builds
libsvn_swig_py-1.la:
  cd subversion/bindings/swig/python/libsvn_swig_py && $(LINK) $(SWIG_PY_LIBS) -
o libsvn_swig_py-1.la $(LT_NO_UNDEFINED) $(libsvn_swig_py_OBJECTS) $(LSWIGPY) ..
/../../../../subversion/libsvn_subr/libsvn_subr-1.la ../../../../../subversion/l
ibsvn_delta/libsvn_delta-1.la $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS) $(LIBS)

Edit that line of code to your liking. If you find a general pattern
to the fix that works on all of your systems, I can patch our build
system to generate build-outputs.mk correctly.

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org