On 9/22/05, David James <james82@gmail.com> wrote:
> On 9/22/05, André Malo <nd@perlig.de> wrote:
> > * djames@tigris.org wrote:
> >
> > > Author: djames
> > > Date: Thu Sep 22 15:22:00 2005
> > > New Revision: 16211
> > >
> > > Modified:
> > > trunk/subversion/bindings/swig/python/svn/delta.py
> > > trunk/subversion/bindings/swig/python/svn/fs.py
> > > trunk/subversion/bindings/swig/python/svn/repos.py
> > >
> > > Log:
> > > Update high-level Python bindings API to make all pool parameters
> > > optional, and to consistently use our new automatic pool management API.
> >
> > Hmm. These changes will create a lot of pools at import time which even may
> > not be used (if the caller chooses to supply its own pool).
> > Furthermore, you leak memory now, because the pools are never cleared. (Or
> > do I miss something magical in the swig stuff?).
> Oops! Very good catch! I didn't realise that method arguments are
> initialized at import time. In that case, the idiom "pool=Pool()" is
> definitely to be avoided. Instead, I'll use "pool=None".
Committed in r16213.
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 22 23:34:29 2005