[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Keywords as Hash 2 - libsvn_wc

From: John Peacock <jpeacock_at_rowman.com>
Date: 2005-09-21 20:37:20 CEST

Julian Foad wrote:
> I agonised over this all afternoon, wondering if the keywords-as-hash
> API is acceptable, and researched the existing use of apr_hash_t in our
> APIs, finding that we hardly ever provide or accept NULL. However, the
> existing use of keywords did use NULL (for svn_subst_keywords_t *), so I
> decided the API is OK as it is.

An additional argument in favor of accepting NULL instead of an empty
hash is that it is much easier to hard code NULL in internal calls where
the keywords are not important/needed.

Although we are moving to cut 1.3 on Friday, it still isn't too late to
change svn_subst_build_keywords2() to return NULL instead of an empty
hash, thus making the usage more consistent.

Thanks for the review!

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 21 20:38:07 2005

This is an archived mail posted to the Subversion Dev mailing list.