[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

rfc on structure changes

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-09-21 14:00:34 CEST

Hi,

   This is a request for modifying the way certain publicly available
structures are written. The below is the only example am able to give...
but its possible that there are more like this...

   svn_ra_plugin_t structure in subversion/include/svn_ra.h. I need to
change a parameter of the svn_commit_callback_t member.
   To do this, I have to
- deprecate svn_ra_plugin_t with svn_ra_plugin2_t
- replace/deprecate all functions using svn_ra_plugin_t

   This is a non-trivial way to make a change to a data structure...

   An easier way to do such a change would be to deprecate only the
member that needs to change with a new member, added at the bottom.

   I know these are not the best ways to achieve what is required here.
I would like start a thread/issue to discuss and implement the changes
required to make life easier for us in future.

   Pl. comment on the above.

Regards,
Madan.

FWIW, am pasting my monologue on the svn-dev channel...
=================================================================
<madan> hi folks, I need some advice
<madan> In subversion/include/svn_ra.h,
<madan> I want to replace the get_commit_editor member of the
svn_ra_plugin_t structure
<madan> to take a svn_commit_callback2_t instead of
<madan> svn_commit_callback_t
<madan> but this would require deprecating the whole of svn_ra_plugin_t
<madan> and replacing all the functions using it
<madan> am wondering if theres an easy way out!
<madan> I was thinking of adding a new member called get_commit_editor2
at the end of the structure...
<madan> and opening an issue to fix this problem....
<madan> the problem - of making changes to structures less intrusive
=================================================================

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 21 13:52:51 2005

This is an archived mail posted to the Subversion Dev mailing list.