[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r16098 - in trunk/subversion: clients/cmdline libsvn_client

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-09-20 23:54:27 CEST

On Tue, 19 Sep 2005 kfogel@collab.net wrote:

> lundblad@tigris.org writes:
> > --- trunk/subversion/libsvn_client/add.c (original)
> > +++ trunk/subversion/libsvn_client/add.c Fri Sep 9 06:33:40 2005
> > @@ -670,7 +670,7 @@
> > svn_client_ctx_t *ctx,
> > apr_pool_t *pool)
> > {
> > - svn_client_commit_info2_t *commit_info2 = NULL;
> > + svn_commit_info_t *commit_info2 = NULL;
> > svn_error_t *err;
>
> Given the type change, the "2" on the end of the variable name isn't
> appropriate anymore, I think.
>
Well, we have an argument with the same name (which doesn't show up in the
patch). Would renaming the argument ret_commit_info be better?

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Sep 20 23:57:28 2005

This is an archived mail posted to the Subversion Dev mailing list.