Re: [PATCH] wc-replacements branch: Implement reverting after svn cp URL PATH replacements

Ivan Zhakov <chemodax@gmail.com> writes:
> > There's one problem with this patch: merge_tests.py 26 fails after
> > applying it. I'm investigating why, but in case I don't resolve the
> > issue tomorrow, I thought I'd let you know.
>
> Oops, on my machine it fails too. I look why is it. Seems I missed
> that svn_wc_add_repos_file called also from merge_file_added().

Ivan, you've been doing terrific work on the wc-replacements branch,
so please don't take this comment as a condemnation:

If the test fails on your machine too, then you can know that before
posting the patch :-). In other words, always run the test suite on a
change before posting the change. No point spending a reviewer's time
on something that can be automatically discovered earlier.

You probably came to this conclusion independently. I just wanted to
confirm that it is standard practice for all of us.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org