On Sun, 18 Sep 2005, Joshua Varner wrote:
> I realize I should have brought up an potential design on
> the list first, but it turned out to be pretty simple.
>
So, let's have the design discussion now instead:-) (Thanks for the patch,
BTW.)
> I do have one question with regard to pool usage,
> should I have used a subpool for the file reading
> part of the patch. I based it on svn_io_read_version_file,
> so, if yes, that function should probably be changed
> as well.
>
The general answer here is that you normally use subpools when there is
some kind of iteration involved. You can read more about this in
hacking.html.
> [[[
>
> If the default hook directory path points to a file,
> read the first line of that file and use it as the path
> to the hook directory. Resolves Issue: 2294.
>
Sounds like you are reimplementing symlinks. For what benefit? I can see a
use case for this under Windows (where symlihnks are available, but less
commonly used), but in that case, it should be an option in a (new) file
in the
conf directory in the repository.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 19 09:08:28 2005