[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] wc-replacements branch: Implement reverting after svn cp URL PATH replacements

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-09-18 00:08:08 CEST

On 9/14/05, Ivan Zhakov <chemodax@gmail.com> wrote:
> Hi, Erik and Devs!
>
> [[
> Implement reverting after svn cp URL PATH replacements.
>
> * subversion/libsvn_wc/update_editor.c
> (svn_wc_add_repos_file): Check if we're replacing the file then copy
> text base and prop base
> to text and prop revert file.
> * subversion/tests/clients/cmdline/revert_tests.py
> (revert_replacement_with_props): New helper for
> revert_wc_to_wc_replace_with_props and
> revert_repos_to_wc_replace_with_props.
> (revert_wc_to_wc_replace_with_props): Renamed from
> revert_replace_with_history_with_props. Use new helper
> revert_replacement_with_props.
> (revert_repos_to_wc_replace_with_props): New test of reverting svn cp URL PATH
> replacements.
> (test_list): Add new test revert_repos_to_wc_replace_with_props. Rename
> revert_replace_with_history_with_props to revert_wc_to_wc_replace_with_props.
> ]]

Hi Ivan!

Sorry for my late reaction, I've had a busy week.

There's one problem with this patch: merge_tests.py 26 fails after
applying it. I'm investigating why, but in case I don't resolve the
issue tomorrow, I thought I'd let you know.

Also, breser pointed a problem with his early work on the branch:
http://svn.haxx.se/dev/archive-2005-03/0370.shtml

He said in reaction to Philip's comment that svn_wc_add_repos_file()
and install_file() both should probably be refactored to make 'A'dd
loggy. I haven't looked at that yet, but maybe we can work together on
resolving that. That's why I cc'ed him: I hope he can elaborate on the
changes he had in mind.

bye,

Erik.
Received on Sun Sep 18 00:08:54 2005

This is an archived mail posted to the Subversion Dev mailing list.