Re: [PATCH] Fix for issue 2394 no error dialog if lock command failed

On Thu, 08 Sep 2005, Jani Averbach wrote:

> On 2005-09-08 15:30-0700, Daniel Rall wrote:
> >
> > Being a perhaps a little closer to this code, I did feel comfortable making
> > this commit. However, I completely agree with Jani that a regression test
> > would be a good thing here.
>
> Sure, and that was my point. Now the fix is in the trunk and there
> won't be any incentive to write a regression test for it and it will
> be forgotten in about few weeks. However, it was a genuine bug and it
> revealed a hole in the unit tests.
>
> My point was: Don't commit without a regression test.
 
I know. :-)

> The sad thing is that I have been so hopelessly busy that I haven't
> had time to do even that small regression test.

...and I'm perpetually in the same boat, which was why I made the commit.
John Szakmeister commited a regression test today.

- Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 10 07:40:56 2005