[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] l10n crashes

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-09-05 20:59:24 CEST

On Mon, 5 Sep 2005, Julian Foad wrote:

> Max Bowsher wrote:
> > Julian Foad wrote:
> >
> >> Well, GNU xgettext (v0.14.1) has a "--flag" option for this. Here are such
> >> options covering all of the functions on which we have put "__attribute__
> >> ((format(...)))":
> > ...
> >> Can you add those options into the build system so that they can be used
> >> easily? I don't know where they would go.
> >
> > Excellent, I missed that option.
> >
> > Here is a patch which makes use of it.
> > This increases the requirements to run "make locale-gnu-{po-update,pot}"
> > to gettext 0.13 or later.
> > I think this is acceptable, given the small set of people who need to
> > use those commands, and the importance of avoiding crashes.
>
> Committed, tweaked, in r16059. I hope it works well.
>
I tested this and it adds a lot of c-format flags to the merged .po file,
as expected. And it fails when you add %s to a message which shouldn't
have one, also as expected.

Thanks for doing this, Julian and Max. I updated TRANSLATING to reflect
the required GNU gettext version.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 5 21:00:20 2005

This is an archived mail posted to the Subversion Dev mailing list.