Max Bowsher wrote:
>> Author: maxb
>> Date: Wed Aug 31 10:23:39 2005
>> New Revision: 16017
>>
>> Modified:
>> trunk/build.conf
>> trunk/subversion/include/svn_ra.h
>> trunk/subversion/libsvn_ra/ra_loader.c
>> trunk/subversion/libsvn_ra/wrapper_template.h
>> trunk/subversion/libsvn_ra_dav/session.c
>>
>> Log:
>> Revert r16010 and r16011. They broke the build on Cygwin, by introducing
>> circular linkage between libsvn_ra and libsvn_ra_{local,dav,svn}.
>
>
>
> Just a quick note to elaborate on why I reverted this change.
>
> Clearly, most of the change is good, we just need to discuss how to
> get the benefits of it without introducing the circular dependencies.
> I'd like trunk to be buildable whilst that discussion is ongoing, so I
> backed out the changes for now.
We need libsvn_ra_util, to get a diamond-like dependency tree:
libsvn_ra
|
+-------------+--------------+
/ | \
libsvn_ra_dav libsvn_ra_svn libsvn_ra_local
\ | /
+-------------+--------------+
|
libsvn_ra_util
We could still expose svn_ra_create_callbacks from libsvn_ra, but it
would only forward to the real implementation in libsvn_ra_util.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 31 21:20:06 2005