[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Authz support in Svnserve

From: <kfogel_at_collab.net>
Date: 2005-08-25 23:39:54 CEST

Branko Čibej <brane@xbc.nu> writes:
> >> /* In the repository conf directory, look for these files. */
> >> #define SVN_REPOS__CONF_SVNSERVE_CONF "svnserve.conf"
> >> #define SVN_REPOS__CONF_PASSWD "passwd"
> >>+#define SVN_REPOS__CONF_AUTHZ "authz"
> >>
> >This isn't really due to your change, but I find both the comment and
> >the names of these constants a bit misleading. These files are just
> >what is looked for *by default*, right? Depending on how the admin
> >configures things for run-time, totally different files might be
> >looked for. I wish the comment and the names expressed this better.
> IIUC, CONF_PASSWD and CONF_AUTHZ are default values for
> svn_config_read, whilst CONF_SVNSERVE_CONF is the name of the config
> file. So you can't really use the same comment for all three, and the
> first two should have a DEFAULT in the name somewhere.

Yes, that's a much better explanation (and you meant "first two" in
your list, not in the order they're in in the code, I presume).

> And woldn't it be nice if "b" were called "baton"
> instead. Single-character variables make my froodleprog itch.

We wouldn't want that, now, would we.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 26 00:39:32 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.