[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 443 : post-commit hook (error) output lost: Step 3

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2005-08-25 09:34:22 CEST

On Thu, 2005-08-25 at 08:13, kfogel@collab.net wrote:
> Madan U Sreenivasan <madan@collab.net> writes:
> > Pl. find attached another small step towards issue #443's solution...
> [snip]
> We usually allocate based on the variable itself, like this:
> sizeof (*commit_info)
> That way if we have to rev the type later, to say svn_commit_info2_t,
> there's only one line to change -- and no possibility of forgetting to
> fix the allocation and thereby getting seg faults :-).
Cool. Good thing. I'll stick to this too.
> The name "svn_helpers.c" is a bit generic, and the "svn" prefix is
> redundant. How would you feel about "types.c" or "constructors.c"
> instead? That would be somewhat descriptive, while being generic
> enough to be useful for other constructors later.
constructors.c would be great. very specific.

am sending a patch too, might be helpful if you are not already finished
tweaking yourself.
Thank you, Karl.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 25 09:26:38 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.