On 24 Aug 2005 17:20:00 -0500, kfogel@collab.net <kfogel@collab.net> wrote:
> dionisos@tigris.org writes:
> > Log:
> > Allow build against newest Neon releases on the 0.25.x line.
> >
> >
> > * configure.in (NEON_ALLOWED_LIST, NEON_LATEST_WORKING_VER): Update.
> >
> > * build/ac-macros/neon.m4 (SVN_LIB_NEON, SVN_NEON_CONFIG): Test for the
> > 0.25.x series to set the SVN_NEON_0_25_0 conditional instead of 0.25.0 only.
>
> The name "SVN_NEON_0_25_0" is getting confusing, since the conditional
> is now really indicating 0.25.0 or higher. Maybe we should rename it
> to SVN_NEON_0_25_X or SVN_NEON_ABOVE_0_25_0 or something. What do you
> think?
I think SVN_NEON_0_25 is good. I won't have time today to do the change though.
bye,
Erik.
> > --- trunk/build/ac-macros/neon.m4 (original)
> > +++ trunk/build/ac-macros/neon.m4 Tue Aug 23 16:38:48 2005
> > @@ -50,9 +50,9 @@
> > NEON_VERSION=`cat $abs_srcdir/neon/.version`
> > AC_MSG_RESULT([$NEON_VERSION])
> >
> > - if test $NEON_VERSION = "0.25.0" ; then
> > + if test -n "`echo \"$NEON_VERSION\" | grep '^0\.25\.'`" ; then
> > AC_DEFINE_UNQUOTED([SVN_NEON_0_25_0], [1],
> > - [Defined if have Neon 0.25.0 instead of 0.24.7.])
> > + [Defined if have Neon 0.25.x instead of 0.24.7.])
> > fi
> >
> > for svn_allowed_neon in $NEON_ALLOWED_LIST; do
> > @@ -123,7 +123,7 @@
> > NEON_VERSION=`$neon_config --version | sed -e 's/^neon //'`
> > AC_MSG_RESULT([$NEON_VERSION])
> >
> > - if test $NEON_VERSION = "0.25.0" ; then
> > + if test -n "`echo \"$NEON_VERSION\" | grep '^0\.25\.'`" ; then
> > AC_DEFINE_UNQUOTED([SVN_NEON_0_25_0], [1],
> > [Defined if have Neon 0.25.0 instead of 0.24.7.])
> > fi
>
> Looks like you left the message unchanged here, unlike in the previous
> hunk.
hmm. right. fixed in r15900.
bye,
Erik.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 25 09:14:30 2005