[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Observations relating to r15828.

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-08-20 01:51:44 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> On Aug 19, 2005, at 12:48 PM, Philip Martin wrote:
>> Well, I haven't done much Subversion coding recently, but working on
>> r15828 leads me to make the following observations:
>> 1. svn_string_compare
>> What a !#*%!# awful name! Does it behave like strcmp or is it one
>> of those new-fangled functions that do the opposite? I had to
>> resort to reading the documentation. Bleah!
> New-fangled? It's as old as Subversion itself! IIRC, svn_string.h
> was the very first thing we wrote when we started coding back in
> summer of 2000. :-)

While strcmp dates from the last millennium :) In hindsight,
svn_string_is_equal (or _are_equal) would have been a better name for
a function with this behaviour.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 20 01:52:36 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.