Observations relating to r15828.

Well, I haven't done much Subversion coding recently, but working on
r15828 leads me to make the following observations:

1. svn_string_compare

   What a !#*%!# awful name! Does it behave like strcmp or is it one
   of those new-fangled functions that do the opposite? I had to
   resort to reading the documentation. Bleah!

2. I18N

   Using _("foo %s bar") defeats gcc's printf format string checking,
   if I insert '#define _(X) X' it starts working. Is there some
   magic way to configure/build so that all the formats get checked?

3. Property prej files.

   I think it is possible for there to be mutiple property conflicts,
   and it looks as if the bits of text written to the prej file are
   not \n separated. Should we add \n to the string literals in
   svn_wc__merge_props or should append_prop_conflict do it?

4. Property encoding

   append_prop_conflict assumes that the property values are valid
   UTF8. It's possible to have properties that are not UTF8 and
   append_prop_conflict will fail, and so the merge will abort.
   Perhaps we should escape non-UTF8 values, or simply write them
   without conversion?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org