[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: python-bindings-improvements review

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-08-17 01:30:49 CEST

Daniel Berlin wrote:

>However, since Branko seemed to be so against it, i thought i'd just
>mention why i don't really agree that this is "spaghetti code".
>
>First off, i should say that i don't agree with the idea that it
>shouldn't t inherit from the Unix Makefile generator. Swig binding
>generation really is like unix makefile generation, much moreso than
>anything else. It So the fact that it inherits from the unix Makefile
>generator really doesn't bother me that much.
>
>
But it doesn't generate makefiles, right? So what's wrong with
inheriting from gen_base?

>The number of windows specific things in it is actually pretty small.
>
>It's small enough that i think the cost of abstracting it and having a
>design like:
>
> gen_swig
> / \
> / \
> / \
> / \
> / \
> / \
> / \
>gen_unix_swig gen_windows_swig
>
>is not really worth it, and i doubt it will become worth it (you guys
>can beat me up later if i turn out to be wrong :P).
>
>
Well, if we have

    gen_base --> gen_swig

and some ifs in gen_swig, then fine. But

    gen_base --> gen_make --> gen_swig

looks like a lie to me.

>There is probably some code that could be moved into the generator
>utilities, etc. David has agreed to do so.
>
>
Yup. The whole generator thing could probably do with another round of
refactoriing, but that's not David's job. (Yet. :-p )

>Other than that, assuming it is tested well by others, i believe it
>should go in.
>
>
I've not tested tnis on Windows yet, and I don't know if anyone has...
lack of time on my part again, etc...

>I'm not sure the procedure for large branch merges where it's unlikely
>you can break it up into more than 2 or 3 patches.
>
>I told David he should probably post the invariably huge patch against
>head and let people pick at it a bit as a start, and we'll go from
>there.
>
>
I think a "svn diff -rFOO:BAR
http://svn.collab.net/repos/svn/branches/python...." is sufficient.
There's n point in posting something anyone can pull from the repository. :)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 17 01:31:40 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.