[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #1935: svn status too verbose with svn:externals definitions

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-08-12 15:14:49 CEST

Scott Palmer wrote:
> I would like to avoid duplicating the string ("Performing..."), but I
> didn't see a simple way to avoid the actual print call the in both
> places with the specific implementation I chose for when "-v -q" was
> specified.
> The reason it is in two places is that I implemented the mode I
> originally wanted for the combination of "-v -q". In that mode the
> "Performing..." message is printed ONLY if it will be followed by some
> other status output for that path. This was not a specific requirement
> of issue #1935, but the expected output of "-v -q" was not specified
> either. Perhaps I should just drop that mode.

To begin with I was thinking that that behaviour would be a funny special case,
inconsistent with the individual meanings of "-q" and "-v", but now I see that
it is OK: the new meaning of "-q" with respect to externals will be something
like "Don't print 'X', and don't print 'Performing...' for a directory if there
are no statuses to report in it."

I have now come to like this extra behaviour.

> If you feel strongly about the "printing from two
> places" issue I might be able to elminate the need for making the
> batons "public" and drop my "-v -q" extension to the original issue.

I still don't like having the code to print it split between two different
places, but leave it in for now and I'll see if I can find a way to combine
them. (Sharing just the text of the message would be a half-way house.)

I look forward to your patch.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 12 15:16:04 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.