On 5-Aug-05, at 1:58 PM, kfogel@collab.net wrote:
> "C. Michael Pilato" <cmpilato@collab.net> writes:
>
>> Scott Palmer <scott.palmer@2connected.org> writes:
>>
>>> Am I correct then in thinking (what I originally thought, but didn't
>>> fully grok) that if I think I need to change anything outside of the
>>> subversion/clients/cmdline folder that I need to slap my self
>>> back to
>>> reality?
>>
>> Sounds correct to me. Though, be gentle when slapping. Maybe "love
>> taps" are more in order, considering this is your first trip into our
>> codebase and all.
>
> I don't know about this. I looked at this problem in some depth, and
> I doubt it can be solved just under subversion/clients/cmdline/. At
> any rate I don't think you should be surprised if changes start being
> required elsewhere...
I managed to get something hacked together does what I wanted
originally. That is, it only prints the "Performing status on..."
message when there is going to be output from the external folder.
And all the changes are contained within the cmdline folder.
But based, on issue #1935 and Julian's comments, this isn't really a
solution to issue #1935, since in that case the "Performing
status..." message shouldn't print either, unless the -v flag was
specified.
But my solution has given me an idea for implementing what is
proposed in issue #1935. I will likely have something later tonight.
BTW, why isn't the existing patch attached to that issue acceptable?
I see that it changes a lot more than the status command.
I want to add a new header file "notify.h" so I can share the
notify_baton struct definition (with my changes) with status_cmd.c.
Is that going to be a problem? (I've currently just pasted a
duplicate definition at the top of status_cmd.c.)
Scott
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 5 21:47:18 2005