[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn status enhancement

From: Scott Palmer <scott.palmer_at_2connected.org>
Date: 2005-08-05 06:13:53 CEST

On 4-Aug-05, at 4:14 PM, kfogel@collab.net wrote:

> Tell you what: if you have time to come up with a patch,
> and send it to the dev@ list, I'll at least do a full review. I can't
> promise to commit it the first time obviously, but it shouldn't be a
> huge patch, and once we get it ship-shape (however many turnarounds
> that takes) I see no reason it can't be committed. I've CC'd the dev@
> list in case anyone has objections.

I took a look at the code just to see how simple this might be. I've
never actually looked at the Subversion code before.

I'm lost.

Well not entirely. I pulled down r15583 of http://svn.collab.net/
repos/svn/branches/1.2.x, that's the branch I occasionally compile
svn from. I figured for now I would stay out of trunk, though I
think you would want a patch against the trunk.

I identified two places that seemed to be where the modifications are
required. In externals.c the method svn_client__do_external_status
(), and in status.c: svn_client_status2()

Now somehow I have to suppress the message printed in
svn_client__do_external_status(), but only if svn_client_status2()
isn't going to output anything. That's basically not possible
(unless I'm missing something big) so the message printing in
svn_client__do_external_status() has to be relocated to
svn_client_status2(). svn_client_status2() needs to be made aware of
when it is processing status for an external item and trigger the
printing of the message, just once, if it finds that it has something
to say.

So far, so good. but not knowing a thing about the structure or
conventions used in the code I'm not sure what the right way would be
to pass the needed information into svn_client_status2(). It looks
like the options are: via svn_client_ctx_t or add another parameter
to svn_client_status2(). But it seems those things are not to be
changed lightly, e.g. the '2' is there so the original remains for
backward compatibility. I don't know how quickly I should jump to
make a svn_client_status3()...

I'm afraid I'm going to take way too much time to come up to speed.
I have time to make a quick patch. I don't think I have time to
learn enough (about the Subversion code) to actually do it though :(

I haven't given up entirely yet though...


P.S. I'm not subscribed to the dev list, so please copy my on any

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 5 06:13:32 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.