Re: Some WC improvements

"Peter N. Lundblad" <peter@famlundblad.se> writes:

> On Mon, 1 Aug 2005, Philip Martin wrote:
>
>> Branko ?ibej <brane@xbc.nu> writes:
>>
>> > We put emtpy-file in there because IIRC it was shown that creating it
>> > for every diff did have a significant impact on speed. It might be
>> > that "it was shown" incorrectly;
>>
>> I put it in, it just seemed the natural thing to do when I was writing
>> the diff code. The reduced IO seemed important at the time because I
>> wasn't aware quite how much other IO went on in libsvn_wc.
>>
> If I'm changing this, I'm planning to create one empty file per diff (and
> only if it is needed, possibly). Can that I/O really be measurable? That
> might be what your saying above;

I've never measured it. I'd be surprised if it was significant given
how much other IO goes on.

> just pointing out that I'm not going to
> create an empty-file per added/deleted file if that wasn't obvious.

repos_diff.c already does that.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org