On Tue, 2 Aug 2005, Julian Foad wrote:
> Peter N. Lundblad wrote:
> > On Mon, 1 Aug 2005, Philip Martin wrote:
> >
> >>Branko ?ibej <brane@xbc.nu> writes:
> >>
> >>>We put emtpy-file in there because IIRC it was shown that creating it
> >>>for every diff did have a significant impact on speed. It might be
> >>>that "it was shown" incorrectly;
> >>
> >>I put it in, it just seemed the natural thing to do when I was writing
> >>the diff code. The reduced IO seemed important at the time because I
> >>wasn't aware quite how much other IO went on in libsvn_wc.
> >
> > If I'm changing this, I'm planning to create one empty file per diff (and
>
> Peter, it's not clear what you mean by "per diff". The command-line client
> svn_cl__diff() calls svn_client_diff[_peg]3() once per explicit target given on
> the command line, and then that calls various functions, some of them
> recursive, to walk directory trees, and then finally the svn_diff library or an
> external diff program is called once per versioned file. Which level of "diff"
> did you mean?
>
Heh, I was unclear. I was referring to diff targets. So if you have tons
of targets on the cmdline, you'll creates tons of empty-files, but you're
creating tons of other temp files, so why bother? This is the "plan", but
not a complete proposal, since I haven't investigated it in detail yet.
I'll do the property related stuff first...
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 2 23:33:32 2005