[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bugs in hook scripts on Windows

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-08-02 02:54:21 CEST

Ben Collins-Sussman wrote:

>
> On Jul 30, 2005, at 7:21 AM, Edwin_Park@mckinsey.com wrote:
>
>>
>> Hi,
>>
>> I discovered a few bugs in Subversion's handling of hook scripts on
>> Windows:
>>
>> * The REPOS parameter that is passed in to the batch script uses a
>> Unix-style forward slash '/' delimiter between the repository base
>> dir and the repository instead of the DOS-style backslash '\'. For
>> example, I have a repository named 'Nexus' under the 'E:\products
>> \CommonServices' directory. The REPOS parameter passed into my batch
>> script is: E:\products\CommonServices/Nexus. This has forced me to
>> resort to hardcoding the repository location in my hook scripts
>> because I cannot use the mangled path that is passed in.
>
>
> You said this is svn 1.2.0 on win2k. Which server are you using,
> apache or svnserve?
>
> Developers: is this indeed a bug?

Yes, I'd say this is a bug. We should always use the system's path
separator whenever we "display" paths to external tools ("svn diff" is
an exception because patch expects forward slashes everywhere). Hook
scripts are definitely external tools.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 2 02:55:29 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.