Ben Collins-Sussman wrote:
>
> On Aug 1, 2005, at 8:15 AM, Julian Foad wrote:
>
>> Ivan Zhakov wrote:
>>
>>> It reproduces every time when I commit something using log message
>>> from file containing escape symbol (0x1A) (see attached
>>>
>>
>> Note that 0x1A is Ctrl-Z, EOF, end-of-file.
>> 0x1B is Ctrl-[, ESC, escape.
>>
>> But that doesn't change the fact that you've found a bug.
>
>
>
> Is this really a bug? I thought that we had recently changed things
> such that control-characters were disallowed in log messages -- that
> the server rejected such messages.
>
> * Does the "400 Bad Request" error coming back from apache have a
> more detailed errorlog attached to it?
>
> * Does ra_local reject the same log message? (i.e. committing via
> file:///)?
If it's truly the case that we disallowed control character, then we
still have a bug. I was able to successfully get the log message in
(unmodified) by providing a bogus log message for the commit, and the
using 'svn ps' to set the svn:log message. It should have failed in the
same manner if we're disallowing control characters in log messages.
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 1 20:49:34 2005