Re: Problem with comment message from file with 0x1A (escape)

On 8/1/05, Ben Collins-Sussman <sussman@collab.net> wrote:
>
> On Aug 1, 2005, at 8:15 AM, Julian Foad wrote:
>
> > Ivan Zhakov wrote:
> >
> >> It reproduces every time when I commit something using log message
> >> from file containing escape symbol (0x1A) (see attached
> >>
> >
> > Note that 0x1A is Ctrl-Z, EOF, end-of-file.
> > 0x1B is Ctrl-[, ESC, escape.
> >
> > But that doesn't change the fact that you've found a bug.
>
>
> Is this really a bug? I thought that we had recently changed things
> such that control-characters were disallowed in log messages -- that
> the server rejected such messages.
>
> * Does the "400 Bad Request" error coming back from apache have a
> more detailed errorlog attached to it?
Apache access.log:
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 390
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND
/try/!svn/bln/527 HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 390
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND
/try/!svn/bln/527 HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:41 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:42 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 390
10.10.3.230 - zhakov [02/Aug/2005:15:17:42 +0400] "PROPFIND
/try/!svn/bln/527 HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:42 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:43 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:43 +0400] "REPORT
/try/!svn/bc/527/test1 HTTP/1.1" 200 158
10.10.3.230 - - [02/Aug/2005:15:17:43 +0400] "PROPFIND /try/test1
HTTP/1.1" 401 546
10.10.3.230 - zhakov [02/Aug/2005:15:17:43 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:43 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:43 +0400] "PROPFIND
/try/!svn/bc/527/test1 HTTP/1.1" 207 688
10.10.3.230 - zhakov [02/Aug/2005:15:17:43 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - - [02/Aug/2005:15:17:44 +0400] "PROPFIND /try/test1
HTTP/1.1" 401 546
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 390
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND
/try/!svn/bln/527 HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "REPORT
/try/!svn/vcc/default HTTP/1.1" 200 630
10.10.3.230 - - [02/Aug/2005:15:17:44 +0400] "PROPFIND /try/test3
HTTP/1.1" 401 546
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND /try/test3
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 390
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND
/try/!svn/bln/527 HTTP/1.1" 207 445
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "PROPFIND /try/test3
HTTP/1.1" 207 676
10.10.3.230 - zhakov [02/Aug/2005:15:17:44 +0400] "REPORT
/try/!svn/vcc/default HTTP/1.1" 200 630
10.10.3.230 - - [02/Aug/2005:15:17:45 +0400] "OPTIONS /try/test1
HTTP/1.1" 401 546
10.10.3.230 - zhakov [02/Aug/2005:15:17:45 +0400] "OPTIONS /try/test1
HTTP/1.1" 200 183
10.10.3.230 - zhakov [02/Aug/2005:15:17:45 +0400] "MKACTIVITY
/try/!svn/act/c55d54dc-4a47-b54f-a1b2-bdfcdf712220 HTTP/1.1" 201 369
10.10.3.230 - zhakov [02/Aug/2005:15:17:45 +0400] "PROPFIND /try/test1
HTTP/1.1" 207 428
10.10.3.230 - zhakov [02/Aug/2005:15:17:45 +0400] "PROPFIND
/try/!svn/vcc/default HTTP/1.1" 207 390
10.10.3.230 - zhakov [02/Aug/2005:15:17:46 +0400] "CHECKOUT
/try/!svn/bln/527 HTTP/1.1" 201 385
10.10.3.230 - zhakov [02/Aug/2005:15:17:46 +0400] "PROPPATCH
/try/!svn/wbl/c55d54dc-4a47-b54f-a1b2-bdfcdf712220/527 HTTP/1.1" 400
371

If you need, I can send ethereal session dump.

> * Does ra_local reject the same log message? (i.e. committing via
> file:///)?
Commiting over ra_local works without such problems.

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org