[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Improve error checking for rev-prop commands (incl. issue #2364)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-31 18:14:08 CEST

Issue #2364 says "--revprop doesn't work with -r BASE/COMMITTED/PREV but [does]
with HEAD".

My analysis is that there are two issues here.

1. It was never intended that a working copy item should be specified as the
target for operating on a revision property. It is accepted, but the
documentation doesn't mention it: the help says "[URL]". Therefore there is no
reason why a revision should be able to be specified relative to a WC target.
However, the error message for such an attempt was inappropriate:

   $ svn proplist --revprop -r BASE
   svn: A path under version control is needed for this operation

The new error message with this patch is:

   $ svn proplist --revprop -r BASE
   svn: Must specify revision explicitly, and not relative to a WC item, when
operating on a revision property

2. Maybe we want an enhancement to allow the revision to be specified relative
to a WC item. I don't see any particular arguments for or against that.

The attached patch fixes that error message and does some more besides. I'll
leave point 2 for now. Reviews or thoughts, please.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 31 18:14:52 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.