[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svncopy.pl fails with spaces in file paths.

From: Michael W Thelen <mike_at_pietdepsi.com>
Date: 2005-07-27 19:00:12 CEST

John Peacock wrote:
>>> Would it be better to guard the parameters inside the SVNCall
>>> subroutine itself, with something like this?
>
> Definitely the right idea; I *was* going to say wrong technique, but
> it's really harmless to quote all of the options (under every shell that
> I am aware of). If you wanted to be parsimonious about quoting you
> could use something like this:

Yep, I decided to quote all options for simplicity, and since we're
depending on the shell to do the right thing with quotes anyway.
Actually, I thought about quoting everything in @commandline, but I
noticed that only @options depends on input from the user -- everything
else is under the script's direct control.

Either implementation should work fine. I think I prefer to quote
everything since it is simpler code to read, though.

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 27 19:01:15 2005

This is an archived mail posted to the Subversion Dev mailing list.