[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628: use a custom crash handler on Windows

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-27 09:02:13 CEST

SteveKing wrote:

>>This is all pretty nifty :-) I notice, however, that the patch isn't quite
>>perfect yet, and I'm not talking about code style :-)
>>
>>[snip]
>>
>>
>>>+typedef BOOL (__stdcall *CrashGetLogFile) (void * crashstate);
>>>
>>>
>>^-- Good, but would be even better as "WINAPI" for those obscure systems
>>that nobody ever uses any more that don't know what an __stdcall is.
>>
>>
>
>You might remember that in the beginning, I had WINAPI there. I only changed
>that to __stdcall in the last patch. Why? Because someone insisted that
>there were still hungarian notations in the code and bad names. Since it
>wasn't mentioned *what* exactly didn't match the standard, I was lost and
>just changed *everything* I would even *remotely* consider MS style in
>naming. And 'WINAPI' defines to __stdcall...
>
>Sure, I could have changed one variable name, send the patch again, get the
>same comment again, change another variable name, send patch again, get the
>same comment again, change yet another variable name, send the patch
>again,...
>You see, trial-and-error with changing styling things is boring.
>
>
"A picture is worth a thousand words." But since we don't have any
pictures in our code (not even real ASCII art), maybe an example will
help. Take a look at

    
http://svn.collab.net/repos/svn/trunk/subversion/libsvn_client/simple_providers.c

search for "WIN32", and read from there. I wrote that bit myself, and I
guarantee the style is as orthodox as it gets. :)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 27 09:03:32 2005

This is an archived mail posted to the Subversion Dev mailing list.