[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628: use a custom crash handler on Windows

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-27 08:44:31 CEST

SteveKing wrote:

> Ok, I guess this will be my last try:

Thanks for persevering, Stefan. I'll commit this in the next few days,
as soon as I find the time to test it.

> I've also uploaded the updated crash report dll to
> http://tortoisesvn.tigris.org/files/documents/406/24329/CrashRpt.dll
> There's a slight problem: that binary was compiled with VS.NET, so it
> relies on the 7.1 C-Runtime. And since svn is compiled with VC6, you
> might want to recompile the dll with VC6 too to avoid additional
> dependencies.

I suppose we should do that... Looking at the DLL API, I assume that if
a version of this DLL that's compiled with VS.NET happens to be on the
system, and gets picked up by the VC6-compiled command-line tools, the
different runtimes shouldn't be a problem. Is that correct?

> If you guys find some styling issues with the patch, please just
> correct them yourself (or at least specify *what* and *where* the
> style doesn't suit your needs, I'm tired of trying to find out what
> exactly you don't like) - fixing the style of this patch would take
> you no more than 5 minutes, but writing a mail about that, me reading
> it, trying to find out what's wrong this time, fix it, write another
> mail, attach the patch again, ... takes much more time.

All right. The part that really doesn't fit our style are the TypeNames
and variableNames that we'd write as type_names and variable_names. I'll
fix those when I commit.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 27 08:47:18 2005

This is an archived mail posted to the Subversion Dev mailing list.