[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_repos.h: Typo in definition of svn_repos_parser_fns2_t?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-26 22:12:47 CEST

David James wrote:
> On 7/26/05, Julian Foad <julianfoad@btopenworld.com> wrote:
>
>>How about the attached patch, folks?
>
> It's good. The SWIG bindings are already using svn_repos_parse_fns2_t
> (without the "r") because they were confused by the typedef. It's
> possible that some other people were using the wrong typedef as well.
> Now our header file is consistent, and I don't think anyone will be
> confused.

Committed in r15443.

> Should we fix svn_repos_parse_fns_t as well? We don't have to -- I can
> tell the SWIG bindings to ignore the inconsistency in the old struct
> definition, since it's deprecated. I'm happy with your patch either
> way. It might be a good idea to briefly mention this in your commit
> message: "We didn't fix the inconsistency in the definition of
> svn_repos_parser_fns_t, since it's deprecated."

Deprecating and replacing something that's already deprecated doesn't make
sense to me, so I didn't. I've followed your suggestion of saying so in the
log message.

Thanks.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 26 22:14:56 2005

This is an archived mail posted to the Subversion Dev mailing list.