[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15400 - in trunk/subversion: include libsvn_repos mod_authz_svn

From: <kfogel_at_collab.net>
Date: 2005-07-26 21:19:48 CEST

Julian Foad <julianfoad@btopenworld.com> writes:
> Is this "iteration done via recursion"? It looks to me like iteration
> done by a loop, plus recursion done by recursion, but then I'm not
> familiar with the config file format being parsed so I may have
> misunderstood it.
>
> Does your comment that our usual loop subpool idiom wouldn't work
> apply in this case? The pool memory used by the checked_groups hash
> would be unaffected (as all additions go into its own pool), but the
> pool memory used by authz_group_walk() (which appears to be only that
> used by "list = svn_cstring_split()") would be bounded by the depth of
> recursion.
>
> In practice there's probably no point given the size of most config
> files, but what am I missing in theory?

Well, really this is iteration via a combination of iteration and
recursion :-). Overall, the code iterates over a list of groups; the
list is the set of groups reachable by reference from some initial
group.

But you're right: we could use a subpool for the for-loop, and then
the pool growth would be bound by just the depth of the recursion.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 26 22:12:14 2005

This is an archived mail posted to the Subversion Dev mailing list.