[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-07-25 22:24:21 CEST

On Mon, 25 Jul 2005, Mark Phippard wrote:

> I think there is a problem that no one has pointed out yet here, and that
> is that once you start offering style review, or even a review that gets
> into some of the substance there is almost an implicit acceptance that the
> patch itself is worthy of inclusion. If it later turns out that there are
> some legitimate exceptions, then it leads to more hard feelings than were
> necessary. "Why did you make me cleanup and resubmit a patch 3 times only
> to then tell me there is no way you would commit it?"
+1. Very good point.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 22:25:22 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.