[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_repos.h: Typo in definition of svn_repos_parser_fns2_t?

From: David James <james82_at_gmail.com>
Date: 2005-07-25 21:51:12 CEST

In svn_repos.h, we declare a struct using the name
"svn_repos_parse_fns2_t", and then we typedef it using the
slightly-different name svn_repos_parser_fns2_t. This same
inconsistency also applies to svn_repos_parser_fns_t. Is this a typo?
If so, I can think of two ways to fix it:
1. Fix the typo. Only use the name "parser" to describe the structure,
not "parse", since "parser" is the canonical name.
2. Declare the struct as "parser", but then include a deprecated
typedef for compatibility.

Which solution do you think is better?

Cheers,

David

P.S. This inconsistency causes problems in the SWIG bindings, because
SWIG thinks that the name of the struct is svn_repos_parse_fns2_t,
even though the struct is not typedef'd under that name.

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 21:51:58 2005

This is an archived mail posted to the Subversion Dev mailing list.