[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch reviewing: style vs. content [was: [PATCH] Issue 1628]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-25 19:44:56 CEST

Mark Phippard wrote (in an email entitled "Re: [PATCH] Issue 1628"):
>
> [...] I think if you are inclined to
> review a patch the first thing you should ask yourself is whether you have
> all of the "meta-information" you need to do so. Does the log message or
> the email include enough of this information so that you are clear about
> and agree with the objectives? [...]

Excellent advice. Thanks.

But doesn't that meta-information including having a relevant Subject line on
the email? :-) Hint, hint, nag, nag! Have you noticed that's one of my pet
peeves?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 19:47:40 2005

This is an archived mail posted to the Subversion Dev mailing list.