Re: [PATCH] Issue 1628

Branko Čibej wrote:

>> I don't like the idea of command-line programs popping up dialogue
>> boxes. This is especially annoying when the program in question is a
>> server, such as svnserve. I'd like to have a way to configure the
>> crash reporter to dump the data in a text file instead, and perhaps
>> leave a pointer to that file in the event log.
>>
>> That would require a change to the crashreporter dll itself.
>
> Yes.

So you're volunteering to rewrite the crashreporter?

> But more important: we're talking about server administration here.
> Servers usually run unattended. The biggest pain in the ass about
> Windows (as a server OS) is that 99% of the server software running on
> it assumes that someone will always monitor the server through a GUI.
> Your crash report code even assumes that the box actually has a mail
> client installed.

Wrong. The crash report code doesn't assume that a mail client is
installed. You also can just save the zipped crashreport somewhere if
you like.
And honestly, I've never seen a windows server for which administration
was done through some telnet like app but always either directly (server
connected to monitor) or via remote desktop apps.

> An administrator can view the event log remotely (without a GUI login),
> and can get at files on the server remotely.

True.

> The patch itself is almsot there, I only counted one tab, a few cases of
> hungarian notation, and some funny indentaion and space-before-paren not
> consistent with the rest of the file.

This is now the third time you mention hungarian notation and 'funny
indentation'. Honestly, can't you just tell me directly which variable
names you still don't like or where the 'funny' indentation is?
If you're referring to the 'HMODULE' - that's not a variable and
required by the API (check the MSDN).
Also, I indented every line by two spaces, added two more spaces after
an 'if' for the '{' and another two spaces for the code after '{' - as
far as I can see that's the same format as the rest of the file has.

> But before we go and iron out these nits, let's solve the problem of the
> format of the crash reports themselves, please.

As far as I'm concerned, that's as far as I go. If you don't like the
patch, just don't use it.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org