[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Issue #2291 - 'svn ls -v' should return locking information - V4

From: Alexander Thomas <kca.alexander_at_gmail.com>
Date: 2005-07-25 08:38:04 CEST

Ben Collins-Sussman wrote:

> Unfortunately, now we're faced with two choices, neither of which is
> optimal:
>
> * do a network request to get the dirents, then do N more network
> requests to fetch the lock on each dirent. This is what you're
> currently doing.
> or
> * do a network request to get the dirents, then do one more network
> request to fetch *all* locks below the path.
>
> After some discussion in the Chicago office, we all agree that's it's
> Less Evil to hold the entire hash of locks in memory than to make N
> network requests.

Here I am posting a new version of the patch which will hold the entire
hash of locks in memory and does the rest.

Regards
-Alexander Thomas (AT)

Fix issue #2291: 'svn ls -v' should return locking information.

* subversion/include/svn_types.h
  (svn_dirent2_t): New struct.
  (svn_dirent_t): Deprecated and moved to group it with new struct.

* subversion/libsvn_ra_local/ra_plugin.c
  (svn_ra_local__get_dir): Gets lock information and moved towards
  the end to avoid compile time warning.

* subversion/clients/cmdline/ls-cmd.c
  (print_dirents): Print lock information.
  (print_dirents_xml): Print lock information in xml.

* subversion/clients/cmdline/main.c
  Mention locking information in the help text for 'svn ls'.

* subversion/clients/cmdline/dtd/list.dtd
  Updated DTD file.

* subversion/libsvn_ra_svn/client.c
  (ra_svn_get_dir): Gets lock information.

* subversion/libsvn_ra_svn/protocol
  Doc updated to refelect change in svnserve protocol.

* subversion/libsvn_ra_dav/fetch.c
  (svn_ra_dav__get_dir): Gets lock information.

* subversion/svnserve/serve.c
  (get_dir): Modified svnserve to return lock information.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Jul 25 11:37:33 2005

This is an archived mail posted to the Subversion Dev mailing list.