[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] remove textdomain()

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-07-25 02:30:04 CEST

Hi,

In <Pine.LNX.4.55.0507250031570.4634@localhost.localdomain>
  "Re: [PATCH] remove textdomain()" on Mon, 25 Jul 2005 00:36:05 +0200 (CEST),
  "Peter N. Lundblad" <peter@famlundblad.se> wrote:

> > [[[
> > * subversion/include/svn_nls.h (svn_nls_environment_init),
> > * subversion/libsvn_subr/nls.c (svn_nls_environment_init):
> > Rename to svn_nls_init() and override.
> >
> Better to say that this function was removed and to describe the change to
> svn_nls_init (i.e. move the implementation there and don't set the text
> domain).
>
> Else, +1.

I changed to the following:

  * subversion/include/svn_nls.h (svn_nls_environment_init),
  * subversion/libsvn_subr/nls.c (svn_nls_environment_init):
    Remove. Move the implementation to svn_nls_init().

  * subversion/libsvn_subr/nls.c (svn_nls_init):
    Don't set the current message domain.

and committed in r15415.

> Thanks for doing this (and taking a look at the libraries as
> well; I just assumed we didn't use plain gettext there...).

You're welcome.

Cheers,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 02:32:09 2005

This is an archived mail posted to the Subversion Dev mailing list.