[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: nls.c and svn_nls.h (new files): insufficient #include statements

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-07-24 12:49:08 CEST

Kouhei Sutou wrote:
> Julian Foad <julianfoad@btopenworld.com> wrote:
>>subversion/include/svn_nls.h needs to include "svn_types.h" to get the
>>declaration of svn_error_t, so that it can stand alone (i.e. it should not
>>require other files to have been included before it).
>>
>>subversion/libsvn_subr/nls.c needs to include svn_nls.h to get the prototypes
>>of the functions that it implements, so that they can be verified to have the
>>same signature. I choose to have a compiler warning when that is not done. It
>>should include it before any other Subversion header files (and, ideally,
>>before any other header files) to verify that "svn_nls.h" has no prerequisites.
>>
>>I can do this if you want - just say so.
>
> +1
> Please do.

Done in r15403. I looked at some of our other files and noticed that they are
generally not including the header containing their prototypes before other
headers, so they are not verifying the lack of prerequisites for their headers.
  Therefore I didn't make that a goal of this commit.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 24 12:50:04 2005

This is an archived mail posted to the Subversion Dev mailing list.