[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: nls.c and svn_nls.h (new files): insufficient #include statements

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-07-24 07:14:14 CEST

Hi,

In <42E2D7AF.2000301@btopenworld.com>
  "nls.c and svn_nls.h (new files): insufficient #include statements" on Sun, 24 Jul 2005 00:50:07 +0100,
  Julian Foad <julianfoad@btopenworld.com> wrote:

> subversion/include/svn_nls.h needs to include "svn_types.h" to get the
> declaration of svn_error_t, so that it can stand alone (i.e. it should not
> require other files to have been included before it).
>
> subversion/libsvn_subr/nls.c needs to include svn_nls.h to get the prototypes
> of the functions that it implements, so that they can be verified to have the
> same signature. I choose to have a compiler warning when that is not done. It
> should include it before any other Subversion header files (and, ideally,
> before any other header files) to verify that "svn_nls.h" has no prerequisites.
>
> I can do this if you want - just say so.

+1
Please do.

Cheers,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 24 07:15:46 2005

This is an archived mail posted to the Subversion Dev mailing list.