[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header

From: <kfogel_at_collab.net>
Date: 2005-07-23 02:24:03 CEST

Thanks for the patch -- but you may have missed the big thing about
this issue: that the change can't be made before 2.0, because of
interface promises. (Anyway, we'd have to discuss it a lot to change
it before then.) That's why the issue is set so far in the future.

-Karl

Christopher Ness <chris@nesser.org> writes:
> On Fri, 2005-07-22 at 17:28 +0100, Julian Foad wrote:
> > kfogel@collab.net wrote:
> > > David Faure <faure@kde.org> writes:
> >
> > [Replacing "N lines" with]
> > >>"N" has the huge advantage that only people writing parsers will look there
> > >>(after the documentation tells them to), whereas normal people (like me)
> > >>reading the logs won't confuse this for "number of lines changed in the file".
> <snip>
> > > Would anyone object to us reopening the issue with this proposal, then?
> > > For 2.0, of course.
> >
> > Please do. That confusion is very real (it got me when I was a newbie), and
> <snip>
>
> Going for some low hanging fruit here with this patch, if it is decided
> to remove the units for the lines output. I had a peak under the hood,
> while I was in there made and tested the patch.
>
> It looks like the term "lines" is not translated (only strings in _()
> right? maybe?) in subversion/clients/cmdline/log-cmd.c:185
>
> I didn't do the whole "Patch By: ;Analysis By:" tracking since this
> change seems trivial... the "Analysis By:" list would be longer than
> the patch.
>
> Cheers,
> Chris
> --
> PGP Public Key: http://www.nesser.org/pgp-key/
> 19:52:56 up 2:44, 2 users, load average: 0.33, 0.37, 0.43
>
> [[[
> * subversion/clients/cmdline/log-cmd.c
> (log_message_receiver): Removed hardcoded string "line[s]" from log
> header. Users mistake this last field as the number of lines changed
> in the transaction. It is not.
>
> Discussion thread: http://svn.haxx.se/dev/archive-2005-07/0818.shtml
> ]]]
> Index: subversion/clients/cmdline/log-cmd.c
> ===================================================================
> --- subversion/clients/cmdline/log-cmd.c (revision 15393)
> +++ subversion/clients/cmdline/log-cmd.c (working copy)
> @@ -182,10 +182,7 @@
> if (! lb->omit_log_message)
> {
> lines = svn_cstring_count_newlines (msg) + 1;
> - SVN_ERR (svn_cmdline_printf (pool,
> - (lines != 1)
> - ? " | %d lines"
> - : " | %d line", lines));
> + SVN_ERR (svn_cmdline_printf (pool, " | %d", lines));
> }
>
> SVN_ERR (svn_cmdline_printf (pool, "\n"));

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 23 03:17:34 2005

This is an archived mail posted to the Subversion Dev mailing list.