[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header

From: Christopher Ness <chris_at_nesser.org>
Date: 2005-07-23 02:21:16 CEST

On Fri, 2005-07-22 at 17:28 +0100, Julian Foad wrote:
> kfogel@collab.net wrote:
> > David Faure <faure@kde.org> writes:
>
> [Replacing "N lines" with]
> >>"N" has the huge advantage that only people writing parsers will look there
> >>(after the documentation tells them to), whereas normal people (like me)
> >>reading the logs won't confuse this for "number of lines changed in the file".
<snip>
> > Would anyone object to us reopening the issue with this proposal, then?
> > For 2.0, of course.
>
> Please do. That confusion is very real (it got me when I was a newbie), and
<snip>

Going for some low hanging fruit here with this patch, if it is decided
to remove the units for the lines output. I had a peak under the hood,
while I was in there made and tested the patch.

It looks like the term "lines" is not translated (only strings in _()
right? maybe?) in subversion/clients/cmdline/log-cmd.c:185

I didn't do the whole "Patch By: ;Analysis By:" tracking since this
change seems trivial... the "Analysis By:" list would be longer than
the patch.

Cheers,
Chris

-- 
PGP Public Key: http://www.nesser.org/pgp-key/
19:52:56 up 2:44, 2 users, load average: 0.33, 0.37, 0.43

Received on Sat Jul 23 02:20:45 2005

This is an archived mail posted to the Subversion Dev mailing list.