[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: Olleg Samoylov <olleg_at_mipt.ru>
Date: 2005-07-22 16:46:52 CEST

kfogel@collab.net wrote:
> Olleg wrote:
>
>> I can't undestand official position of subversion developers.
>> Obviously this is bug because svn don't work as expected. When I
>> write 1 line message to log, I expect 1 line message in log. Clear
>> and simple.
>
> Well, you didn't write one line :-). You wrote a line, followed by a
> newline, followed by a line that promised its own removal at commit
> time, along with everything following it. And that's exactly what
> happens right now.

I undestand why this happens. But your can't undestand one simple thing.
One line message is always one line message. And every human can approve
it. No matter how computer make wrong decision.

> If you truly want one line, why not just remove everything but that
> one line?

As I already said, if a bug have a workaround it don't begin looked like
a customizable feature.

> I don't think the patch is an improvement, because it's not clear that
> the current behavior is incorrect. Defaulting to having the newline
> seems reasonable, at least as reasonable as not having it.

Well, let me explain again. "svn log" don't expect EOL at the end. "svn
commit --message", "svn commit --file" and "svn commit" (with editor)
don't add EOL if it not exist. Almost code wroted as if log message have
not trailing EOL.

There is chose. Rewrite almost code to support log message with trailing
EOL, as Greg like. Or fix bug. Or do nothing? What your prefer?

IMHO, will be convenient remove all white spaces at the end, not only
EOL. They arised by mistype usually. Don't have any useful information.
And invisible for human to fix it manualy.

Do you have argument to negate this?

-- 
Olleg Samoylov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 16:46:28 2005

This is an archived mail posted to the Subversion Dev mailing list.