[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: <kfogel_at_collab.net>
Date: 2005-07-22 06:27:32 CEST

Philip Martin <philip@codematters.co.uk> writes:
> kfogel@collab.net writes:
> > At this point I've begun to suspect that two or more different
> > problems are being combined here, and would appreciate a concise bug
> > report that states exactly what is wrong with Subversion: what was the
> > expected behavior, and what was the actual behavior?
>
> Someone using the commit editor to create a commit message like
>
> one line
> --This line, and those below, will be ignored--
>
> _M .
>
> creates a raw log message "one line\n", the patch removes the trailing
> \n so that the raw log message is "one line".

Thank you for the summary. This much I garnered from the original
message, and summarized it as "Problem (3)" in this message:

   http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=102858

I somehow had gotten the feeling that the problem had drifted, from
subsequent messages in the thread. However, reading over them again
now, I don't think there was much drift, there were just a lot of
short but distracting tangents.

I don't think the patch is an improvement, because it's not clear that
the current behavior is incorrect. Defaulting to having the newline
seems reasonable, at least as reasonable as not having it. And the
workaround is simply to remove

   "\n--This line, and those below, will be ignored--"

and everything after it manually. So right now, I think I agree with
Greg. If this patch fixes a bug for some people, it introduces a bug
for others.

Olleg wrote:
> I can't undestand official position of subversion
> developers. Obviously this is bug because svn don't work as
> expected. When I write 1 line message to log, I expect 1 line message
> in log. Clear and simple.

Well, you didn't write one line :-). You wrote a line, followed by a
newline, followed by a line that promised its own removal at commit
time, along with everything following it. And that's exactly what
happens right now. If you truly want one line, why not just remove
everything but that one line?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 07:19:28 2005

This is an archived mail posted to the Subversion Dev mailing list.