[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15343 - in trunk/subversion: libsvn_subr

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-07-21 05:48:29 CEST

Hi,

In <Pine.LNX.4.55.0507202228530.3216@localhost.localdomain>
  "Re: svn commit: r15343 - in trunk/subversion: libsvn_subr" on Wed, 20 Jul 2005 22:33:52 +0200 (CEST),
  "Peter N. Lundblad" <peter@famlundblad.se> wrote:

> +1. Some log message nits below.

I committed in r15374.

> > * subversion/include/svn_nls.h:
> > - Add '@since New in 1.3.'
> > - Fix markups.
> >
> Say what function docs you fixed. I'd be lazier than you and just say
> "Docstring fixes" or something because we don't need that level of detail,
> but thats a matter of taste and I leave it up to you.

I used "Docstring fixes".

> > * subversion/libsvn_subr/cmdline.c(svn_cmdline_init),
> > subversion/libsvn_subr/nls.c(svn_nls_environment_init):
> ^ Missing *.

I didn't add '*' because HACKING says that:

  As an exception to the above, if you make exactly the same change in
  several files, list all the changed files in one entry. For example:

     * subversion/libsvn_ra_pigeons/twirl.c,
       subversion/libsvn_ra_pigeons/roost.c:
       Include svn_private_config.h.

Is it OK?

Cheers,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 21 05:49:11 2005

This is an archived mail posted to the Subversion Dev mailing list.