[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15343 - in trunk/subversion: libsvn_subr

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-07-20 22:33:52 CEST

On Wed, 20 Jul 2005, Kouhei Sutou wrote:

> In <20050719.215156.12661349.kou@cozmixng.org>
> "Re: svn commit: r15343 - in trunk/subversion: libsvn_subr" on Tue, 19 Jul 2005 21:51:56 +0900 (JST),
> Kouhei Sutou <kou@cozmixng.org> wrote:
>
> > > >- if (error == SVN_NO_ERROR)
> > > >+ if (err == SVN_NO_ERROR)
> > > >
> > > >
> > > SVN_NO_ERROR is NULL by definition. we usually test this as "if (!err)"
> >
> > Could you fix this problem and commit the patch if you
> > approve the patch?
>
> I re-made a patch. What about the new patch?
>

+1. Some log message nits below.

> [[[
> Fix documentation and coding style.
>
Add "Follow-up to r15343".

> * subversion/include/svn_nls.h:
> - Add '@since New in 1.3.'
> - Fix markups.
>
Say what function docs you fixed. I'd be lazier than you and just say
"Docstring fixes" or something because we don't need that level of detail,
but thats a matter of taste and I leave it up to you.

> * subversion/libsvn_subr/cmdline.c(svn_cmdline_init),

                                    ^ Missing space.
> subversion/libsvn_subr/nls.c(svn_nls_environment_init):
  ^ Missing *.

> - Use err instead of error as svn_error_t * variable name.
> - Fix coding style.
>
> * subversion/libsvn_subr/nls.c(svn_nls_init): Fix coding style.
> ]]]
>
Else, it's fine.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 20 22:34:36 2005

This is an archived mail posted to the Subversion Dev mailing list.