[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-07-20 08:37:04 CEST

SteveKing wrote:

> Hi,
>
> TSVN uses its own crash handler, which in case of an exception saves
> the crashdump and an xml file containing additional information to
> disk and then lets the user send those files (zipped) to an email
> address.
>
> Issue 1628
> http://subversion.tigris.org/issues/show_bug.cgi?id=1628
>
> is about having such a crash handler for the SVN client too.
>
> The attached patch loads the same crash handler dll TSVN uses (if it's
> available - if it can't be found, the client behaves as always. I.e.
> the dll is not required.) and uses it.
>
> So in case of a crash, a dialog pops up telling the user that the
> program has crashed and if (s)he want's to send information about the
> crash to the developers. If the "Send" button is clicked, the default
> mail client is opened with a new mail where the 'to' address is
> already filled in and also the zipfile already attached. All the user
> then has to do is to (hopefully) write what (s)he was doing to make
> the app crash and send the mail.
>
> I've uploaded the compiled dll to
> http://tortoisesvn.tigris.org/files/documents/406/24329/CrashRpt.dll
>
> The sourcecode of the dll is available in the TSVN repository:
> http://tortoisesvn.tigris.org/svn/tortoisesvn/trunk/src/crashrpt/
>
> The dll uses the wtl library (http://wtl.sourceforge.net/) and for OS
> versions < XP a current dgbhelp.dll should be distributed too (the
> dbghelp.dll is available from MS and redistributable).

I'm not against the idea of a custom crash handler, but the patch as it
stands is unacceptable:

    * it uses C++ comments in C code
    * it uses Hungarian naming convention
    * the change doesn't belong in clients/cmdline/main.c, but in
      svn_cmdline_init (or a similar function in libsvn_subr/cmdline.c),
      because there are other command-line utilities that could use this
      functionality.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 20 23:06:29 2005

This is an archived mail posted to the Subversion Dev mailing list.